Update changelog for 0.8.0 and add Lerna Changelog #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaearon Could you review that the new format is OK? I can then cut the release. |
| * `react-scripts` | ||
| * [#944](https://github.com/facebookincubator/create-react-app/pull/944) Crash the build during CI whenever linter warnings are encountered. ([@excitement-engineer](https://github.com/excitement-engineer)) | ||
|
|
||
| Linter warnings and errors will now be checked for during the build when it's run in a continous integration server (the `CI` environment variable is set) and the build will fail if issues are found. See [Continuous Integration](https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#continuous-integration) for more. |
There was a problem hiding this comment.
Nit: continous => continuous
And maybe:
Linter warnings and errors are now checked during a continuous integration build (set by the
CIenvironment variable) and will fail if any issues are found.
|
LGTM |
alexdriaguine
pushed a commit
to alexdriaguine/create-react-app
that referenced
this pull request
Jan 23, 2017
randycoulman
pushed a commit
to CodingZeal/create-react-app
that referenced
this pull request
May 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lerna Changelog allows us to generate a scaffold for the changelog, a list of changes with all the PR and contributor links in place, from labeled GitHub pull requests.
I added the following labels (inspired by Babel's change log which is also made with Lerna Changelog).
tag: new feature: 🚀 New Feature – Features added in this release.tag: breaking change: 💥 Breaking Change – Breaking changes should be accompanied with a migration guide for users in the change log.tag: bug fix: 🐛 Bug Fixtag: enhancement: 💅 Enhancement – Changes to existing features.tag: documentation: 📝 Documentation – Contributions to docs can also be credited in the change log now.tag: internal: 🏠 Internal – Any internal house keeping / refactoring / infra change that doesn't affect the public interface of the tools.Any merged pull request should be tagged with one these labels so it's picked up for change log in the next release. Lerna Changelog also detects which packages were affected by each change and shows this in the log.
This saves a lot of time when doing releases because a large part of the manual work is done automatically. It's still very important to write good descriptions of the changes in the change log, because it's a document meant to be read by humans, not just a list of commits. But having the bulk of the log generated by this tool gives us more time to focus on authoring these descriptions.