Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #1225

Merged
merged 2 commits into from
Dec 10, 2016
Merged

Update CONTRIBUTING.md #1225

merged 2 commits into from
Dec 10, 2016

Conversation

fson
Copy link
Contributor

@fson fson commented Dec 10, 2016

No description provided.

5. Create a change log entry for the release:
* You'll need an [access token for the GitHub API](https://help.github.com/articles/creating-an-access-token-for-command-line-use/). Save it to this environment variable: `export GITHUB_AUTH="..."`
* Run `npm run changelog`. The command will find all the labeled pull requests merged since the last release and group them by the label and affected packages, and create a change log entry with all the changes and links to PRs and their authors. Copy and paste it to `CHANGELOG.md`.
* Edit the change log as necessary. Don't forget to document any breaking changes!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to suggest specifics here. Like "add a four-space indented paragraph after each non-trivial list item" or something.

Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fson fson merged commit 308121d into facebook:master Dec 10, 2016
@fson fson deleted the fson-patch-1 branch December 10, 2016 14:01
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
* Update CONTRIBUTING.md

* Add more detailed change log instructions
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
* Update CONTRIBUTING.md

* Add more detailed change log instructions
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants