Allow the dev server to watch for changes in src/node_modules #2760
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| watchOptions: { | ||
| ignored: /node_modules/, | ||
| ignored: /^([^\/]|\/(?!src))*\/node_modules\//, |
There was a problem hiding this comment.
Does this work on Windows? Strictly checking for / might be problematic.
There was a problem hiding this comment.
Also, I believe this "breaks" for things like src2, as it checks for a prefix of src. Major edgecase.
There was a problem hiding this comment.
I'll update this for Windows.
I'm not familiar with the src2 edgecase. Do you mind elaborating more on this?
This allows users to put a `node_modules` folder in `src` if they want to use absolute imports or imitate the webpack `resolve.alias` config.
|
I've updated this pr to work for windows. I'm not sure I understand the |
|
Sorry for letting this slip through the cracks. Effectively, any directory which starts with Also, I'm not entirely sure what file path is being examined; what if a parent folder is named I'm thinking we might need to generate the regex dynamically with an explicit allowance for |
|
Hello! I'm a bot that helps facilitate testing pull requests. Your pull request (commit 1e71d47) has been released on npm for testing purposes. npm i react-scripts-dangerous@1.0.11-1e71d47.0
# or
yarn add react-scripts-dangerous@1.0.11-1e71d47.0
# or
create-react-app --scripts-version=react-scripts-dangerous@1.0.11-1e71d47.0 folder/Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk! Thanks for your contribution! |
* Allow the dev server to watch for changes in src/node_modules * fix eslint error * fix broken regex * handle trailing slash edge case for file paths Closes facebook#2760 Fixes facebook#3223
* Allow the dev server to watch for changes in src/node_modules * fix eslint error * fix broken regex * handle trailing slash edge case for file paths Closes facebook#2760 Fixes facebook#3223
This allows users to put a
node_modulesfolder insrcif they want to use absolute importsor imitate the webpack
resolve.aliasconfig.This allows users to put a
node_modulesfolder insrcif they want to use absolute importsor imitate the webpack
resolve.aliasconfig.When experimenting with the
src/node_modulestrick mentioned in #1065 I noticed that the dev server wasn't picking up any changes that happened in thesrc/node_modulesfolder. This change makes it so the dev server will correctly notice changes insrc/node_modulesand rebuild while still ignoring thenode_modulesfolder in the root of the project.