Accept version when loading fonts e.g. font-awesome #298
Conversation
ghost
added
the
|
Shouldn't we allow any query string parameters? They wouldn't have any effect anyway. |
|
Ah, I think you're right. Can't think of any harm it could do. |
alexzherdev
force-pushed
the
fix-font-loading
branch
from
5519c92
to
86d21e2
Compare
|
How about this now? |
|
Why not just (?.*)? |
|
I thought about this but somehow it seemed safer to enforce the query string structure. Not sure what exactly I was worried about, sorry 😒 |
alexzherdev
force-pushed
the
fix-font-loading
branch
from
86d21e2
to
27917a1
Compare
| @@ -73,7 +73,7 @@ module.exports = { | |||
| loader: 'json' | |||
| }, | |||
| { | |||
| test: /\.(jpg|png|gif|eot|svg|ttf|woff|woff2)$/, | |||
| test: /\.(jpg|png|gif|eot|svg|ttf|woff|woff2)(\?.*)?$/, | |||
There was a problem hiding this comment.
Also worth doing for mp4/webm in the loader a few lines below
There was a problem hiding this comment.
Yeah I'm not sure how else it's used in the wild, only encountered it with fonts. I wonder if other assets like CSS may need this.
There was a problem hiding this comment.
I think it's relevant for anything that can be referenced in CSS. So CSS itself won't need it but any files will.
There was a problem hiding this comment.
relevant for url(font.woff?v=1.3) in some CSS libs. webpack 2 doesn't need this anymore. cc @mxstbr
There was a problem hiding this comment.
Why does webpack 2 not need this anymore? What am I missing here?
Fixes #295. The version is optional so I didn't extract font extensions into a separate loader.