Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a note with instructions on eslint plugin configuration #348

Merged

Conversation

DiegoCardoso
Copy link
Contributor

I've installed both Sublime Text and Visual Studio Code in order to see if I needed to add any extra configuration to make eslint work.
Since the only editor that I found the issue was Atom, I added
just the instruction for the linter-eslint plugin.

Below is the instruction that I added:

Note: if you are using the linter-eslint plugin on Atom, make sure that Use global ESLint installation option is checked.

Since the only editor that I found the issue was Atom, I added
just the instruction for the linter-eslint plugin.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

You would need to install an ESLint plugin for your editor first.
You would need to install an ESLint plugin for your editor first.

>Note: if you are using the `linter-eslint` plugin on Atom, make sure that **Use global ESLint installation** option is checked.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s make this a regular paragraph, it’s too easy to skip now.

Copy link
Contributor

@gaearon gaearon Aug 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better yet,

A note for Atom linter-eslint users

If you use, ...

(screenshot)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, create that as note with that format or a regular paragraph?

Where should I add the screenshot?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s add a note with that format, it will be visible thanks to the screenshot.
Screenshot should be inline in the note.

@ghost
Copy link

ghost commented Aug 3, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Aug 3, 2016
@gaearon gaearon merged commit cacabba into facebook:master Aug 3, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 3, 2016

Thanks!

@DiegoCardoso
Copy link
Contributor Author

Thank you for being part of my very first pull request! 😄

@DiegoCardoso DiegoCardoso deleted the eslint-add-plugins-instructions branch August 3, 2016 23:00
gaearon pushed a commit that referenced this pull request Aug 22, 2016
* Added a note with instructions on eslint plugin configuration

Since the only editor that I found the issue was Atom, I added
just the instruction for the linter-eslint plugin.

* Change the format of the instructions and add screenshot.
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants