Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies #3785

Merged
merged 3 commits into from
Jan 14, 2018
Merged

Bump dependencies #3785

merged 3 commits into from
Jan 14, 2018

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jan 14, 2018

The usual.

@gaearon gaearon added this to the 2.0.0 milestone Jan 14, 2018
@gaearon gaearon merged commit 75f8e7d into next Jan 14, 2018
gaearon added a commit that referenced this pull request Jan 14, 2018
@gaearon
Bump dependencies (#3785)
7e4657b 
* Bump dependencies

* Use a more sensible way to compile error overlay

* Keep old chalk for global CLI
gaearon added a commit that referenced this pull request Jan 14, 2018
@gaearon
Bump dependencies (#3785)
d0bf090 
* Bump dependencies

* Use a more sensible way to compile error overlay

* Keep old chalk for global CLI
Timer pushed a commit to Timer/create-react-app that referenced this pull request Jan 15, 2018
@gaearon @Timer
Bump dependencies (facebook#3785)
ea46cf4 
* Bump dependencies

* Use a more sensible way to compile error overlay

* Keep old chalk for global CLI
@Timer Timer deleted the dep-bump branch February 7, 2018 21:48
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
@gaearon @akstuhl
Bump dependencies (facebook#3785)
1c424fd 
* Bump dependencies

* Use a more sensible way to compile error overlay

* Keep old chalk for global CLI
@tklever tklever mentioned this pull request May 9, 2018
Closed
@KagamiChan
Copy link

hi @gaearon

I've noticed that the hot reload client from latest/beta react-dev-utils does not work under Internet Explorer 11. And I think the cause is that strip-ansi package was bumped to 4.0.0 in this PR: strip-ansi@4 contains arrow functions which are not compatible with legacy browsers and unluckily webpackHotDevClient imports it.

This package was previously rolled back to 3.x for the same reason (#2691 and #2692). If legacy browser incompat is still a valid issue, It would be better to downgrade it again along with some check to prevent unintended version bump.

May I make a PR for that?

@gaearon
Copy link
Contributor Author

gaearon commented Aug 14, 2018

Hmm. All right!

@gaearon
Copy link
Contributor Author

gaearon commented Aug 14, 2018

Actually I thought we did it now because we should be compiling dependencies automatically. Can you file a separate issue for this so we can investigate?

@KagamiChan
Copy link

I'm sorry I may have made a mistake. Actually I ejected several months ago (when CRA was 1.x) but is still using react-dev-utils, and I was not aware of such change in build config. I'll do some verification for that.

@gaearon
Copy link
Contributor Author

gaearon commented Aug 14, 2018

Ah yeah that's likely the reason. Newer babel preset should handle it.

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@gaearon @Timer
Bump dependencies (facebook#3785)
f309392 
* Bump dependencies

* Use a more sensible way to compile error overlay

* Keep old chalk for global CLI
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @KagamiChan @facebook-github-bot