Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail docs about building for relative path #3970

Closed
wants to merge 1 commit into from
Closed

Detail docs about building for relative path #3970

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2018

Added docs is verified at here.

Hope it will help guys wanna change root path of built app without changing package.json.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@MichaelDeBoey
Copy link
Contributor

This could be avoided if we implement #3834, but a nice addition to the docs tho 🙂

@Timer
Copy link
Contributor

Timer commented Feb 5, 2018

Thanks for your contribution, but PUBLIC_URL has special behavior and is better suited in the Advanced Configuration section (where it lives now).

@Timer Timer closed this Feb 5, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants