Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from uglify-es to terser #4852

Closed
wants to merge 1 commit into from

Conversation

prichodko
Copy link

Recently a terser-webpack-plugin was released and based on a fact that uglify-es is no longer maintained and issues like #4711 and probably couple of more https://github.com/facebook/create-react-app/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+uglify+, I am opening this PR to start a potential discussion of moving to terser.

Terser retains API compatibility with uglify-es, so I just updated necessary package.json and webpack.config files and didn't touch any options, however I am curious if this option

https://github.com/facebook/create-react-app/blob/next/packages/react-scripts/config/webpack.config.prod.js#L132

could be fixed by migration.

Closes #4711 and potentially more.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bugzpodder
Copy link

How can we cleanup terserOptions?

@prichodko prichodko force-pushed the feat/switch-to-terser branch 2 times, most recently from f41e601 to 23e3c0d Compare August 15, 2018 16:32
@prichodko
Copy link
Author

Closing in favour of #4852.

@prichodko prichodko closed this Sep 19, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants