Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove paywalled tutorial link for Storybook #5035

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Remove paywalled tutorial link for Storybook #5035

merged 1 commit into from
Sep 20, 2018

Conversation

imgntn
Copy link
Contributor

@imgntn imgntn commented Sep 19, 2018

Swapping out a paid Storybook video link for free text tutorials!

@imgntn
Remove paywalled tutorial link for Storybook
273b194 
Swapping out a paid Storybook video link for free text tutorials!
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Timer
Copy link
Contributor

Timer commented Sep 19, 2018 •
edited
Loading

🎉

Can you make the CLA bot happy?

@Timer Timer modified the milestones: 100.0.0, 2.0.0 Sep 19, 2018
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer Timer merged commit 6164a26 into facebook:master Sep 20, 2018
@Timer
Copy link
Contributor

Timer commented Sep 20, 2018

Whoops, didn't even notice this landed on the master branch by accident. Fixing ...

Timer pushed a commit to Timer/create-react-app that referenced this pull request Sep 20, 2018
@imgntn @Timer
Reorder Storybook resources to be more helpful (facebook#5035)
7d41493
@imgntn
Copy link
Contributor Author

imgntn commented Sep 20, 2018

Ah, sorry about that, I meant to reopen this against next. Apologies

@Timer
Copy link
Contributor

Timer commented Sep 20, 2018

It's fixed, thanks!

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@imgntn @Timer
Reorder Storybook resources to be more helpful (facebook#5035)
8fd207a
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@imgntn @facebook-github-bot @Timer