Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust ESLint configuration for v5 #5051

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Sep 21, 2018

ESLint 5 dropped experimentalObjectRestSpread, the generators feature has been gone for a while, and we should support the latest JavaScript features via ecmaVersion 6 (2015) => 9 (2018).

eqeqeq also has a new smart mode that is a little more relaxed than allow-null, permitting == when testing a string literal against typeof.

Follow up to #5050.

@Timer Timer added this to the 2.0.0 milestone Sep 21, 2018
@Timer Timer mentioned this pull request Sep 21, 2018
@Timer Timer merged commit ca2e9f0 into facebook:next Sep 21, 2018
@Timer Timer deleted the eslint-config-adjustments branch September 21, 2018 12:07
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants