Disable Symbol typeof transform #5278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think leaving it on was a mistake. It causes some issues (#5267), but more fundamentally, it's a leaky abstraction. It tries to make
typeofbehave to return'symbol'for Symbols by hijacking every singletypeof. This leads to slowing down all code for the benefit of edge cases that likely won't work 100% correctly anyway. It definitely makes React slower (I've measured this before).I considered disabling it just for
node_modulesat first. But I don't see good reasons to leave it on in application code either. Code that relies on this is inherently fragile and can break in other ways.We're early enough in 2.x cycle that I consider this a bugfix. It definitely will fix bugs for some libraries in
node_modules. And arguably performance improvements in the application code are worth the edge case issues that this would uncover.