Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callouts and logo #5341

Merged
merged 2 commits into from
Oct 8, 2018
Merged

Conversation

selbekk
Copy link
Contributor

@selbekk selbekk commented Oct 7, 2018

localhost_3000_

This pull request simplifies the front page of the docs a bit, as it contained a few sections we don't need for a first release.

The React logo was borrowed from the template folder - I guess it's fine to duplicate like this?

Adresses #5238

Copy link
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👍

@amyrlam
Copy link
Contributor

amyrlam commented Oct 8, 2018

Not sure about the Travis failure https://travis-ci.org/facebook/create-react-app/jobs/438291393#L2874, but it seems like it can be merged to docusaurus

@selbekk
Copy link
Contributor Author

selbekk commented Oct 8, 2018

Yeah all of my PRs have failed their Travis check, but it doesn't look like anything related to my code.

Merging then :)

@selbekk selbekk merged commit bc1b021 into facebook:docusaurus Oct 8, 2018
@selbekk selbekk deleted the add-callouts-and-logo branch October 8, 2018 05:31
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants