Add allowESModules option to babel-preset-react-app #5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
Bump? |
Timer
suggested changes
Nov 18, 2018
| @@ -29,6 +29,7 @@ module.exports = function(api, opts, env) { | |||
| var isEnvProduction = env === 'production'; | |||
| var isEnvTest = env === 'test'; | |||
|
|
|||
| var allowESModules = validateBoolOption('allowESModules', opts.allowESModules, true); | |||
There was a problem hiding this comment.
Let's make this default to isEnvDevelopment || isEnvProduction and use the existing name.
Suggested change
| var allowESModules = validateBoolOption('allowESModules', opts.allowESModules, true); | |
| var useESModules = validateBoolOption('useESModules', opts.useESModules, isEnvDevelopment || isEnvProduction); |
| @@ -140,7 +141,7 @@ module.exports = function(api, opts, env) { | |||
| // https://babeljs.io/docs/en/babel-plugin-transform-runtime#useesmodules | |||
| // We should turn this on once the lowest version of Node LTS | |||
| // supports ES Modules. | |||
| useESModules: isEnvDevelopment || isEnvProduction, | |||
| useESModules: allowESModules ? isEnvDevelopment || isEnvProduction : false, | |||
There was a problem hiding this comment.
Consequently, this becomes simpler (or use the shorthand syntax):
Suggested change
| useESModules: allowESModules ? isEnvDevelopment || isEnvProduction : false, | |
| useESModules: useESModules, |
|
Seams reasonable, updated to match requested changes. |
Timer
suggested changes
Nov 19, 2018
Co-Authored-By: Pajn <rasmus@eneman.eu>
|
I misunderstood and thought you ment only the varaible name, but that's an easy fix |
|
I think this behavior is best -- if undefined, it uses old (reasonable) logic. If the user defines it, uses that value. Does this seem good to you? |
|
Absolutely, It's even cleaner code. 👍 |
Timer
approved these changes
Nov 21, 2018
dardub
added a commit
to OffBase/create-react-app
that referenced
this pull request
Nov 27, 2018
* upstream/master: (210 commits) Support setupTests.ts (facebook#5698) Remove unnecessary whitespace in template HTML Run prettier on HTML files (facebook#5839) Some Grammar fixes (facebook#5858) Fix link to page about running tests (facebook#5883) fix: make typescriptformatter support 0.5 of fork checker (facebook#5879) Always test with the latest stable Node version on Travis (facebook#5546) Fix propertyDecorator test Upgrade babel deps Fix annotated var test Fix TypeScript decorator support (facebook#5783) fix: add `sideEffects: false` to react-error-overlay (facebook#5451) Add allowESModules option to babel-preset-react-app (facebook#5487) Make named-asset-import plugin work with export-as syntax (facebook#5573) React native repository updated in README.md (facebook#5849) extra polyfills must be included manually (facebook#5814) Rename 'getting started' link to 'docs' (facebook#5806) docs: Simplify installing Storybook with npx (facebook#5788) Don't polyfill fetch for Node -- additional files (facebook#5789) docs: Change Storybook install documentation (facebook#5779) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the discussion in #5452