Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to steps for publishing GitHub User Page #6095

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Changes to steps for publishing GitHub User Page #6095

merged 2 commits into from
Jan 17, 2019

Conversation

steventan
Copy link

@steventan steventan commented Dec 27, 2018

Action taken:
Update to Documentation. Removed the the step for switching to 'gh-pages' branch as it is no longer a viable option.

Reason:
As per stated on GitHub, Pages for User and Organisation could only be published from 'master' branch. The option to switch to another branch is no longer a viable option.

Extract from GitHub:
"If your site is a User or Organization Page that has a repository named .github.io or .github.io , you cannot publish your site's source files from different locations. User and Organization Pages that have this type of repository name are only published from the master branch."

GitHub reference:
https://help.github.com/articles/configuring-a-publishing-source-for-github-pages/

Note:
In the case of a user's page, users only need to do the second step, instead of two.

"Additionally, tweak your package.json scripts to push deployments to master" solely would suffice as per tested on my own Github User Page. (StevenTan.GitHub.io)

Thanks,
Steven

Remove the the step for switching to gh-pages branch as it is no longer a viable option.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@steventan
Copy link
Author

steventan commented Jan 14, 2019

Can I know if there are any updates to this PR? I got to know several of my friends apparently were experiencing the same issue following the existing documentation.

Thanks.

@ianschmitz
Copy link
Contributor

Do you mind merging/rebasing master to get the Travis build to pass?

@steventan
Copy link
Author

Sorry to bother but may I know is there anything holding up that I could be of help? It has successfully passed the Travis build.

@ianschmitz ianschmitz added this to the 2.1.4 milestone Jan 17, 2019
@ianschmitz ianschmitz merged commit 803946f into facebook:master Jan 17, 2019
@ianschmitz
Copy link
Contributor

It's in now. Thanks!

@steventan steventan deleted the patch-1 branch January 17, 2019 02:44
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants