Avoid tons of *.json.gzip-files created in project root when running with docker node #620
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
| cacheDirectory: true, | ||
| // It enables caching results in ./node_modules/.cache/create-react-app/ | ||
| // directory for faster rebuilds. | ||
| cacheDirectory: findCacheDir({ name: 'create-react-app' }), |
There was a problem hiding this comment.
The convention seems to be that this should be the project name from package.json. Since this file is used by react-scripts, should we use react-scripts as the name here?
|
I updated the PR |
|
I tested this using the offical Node Docker image and it works, the cache files were stored in Thanks for the PR @thangngoc89! |
|
When is the next release of this planned? |
|
Within a few days. |
|
This should be fixed in 0.4.2. |
|
@gaearon Upgrade went smooth, and no gzip in my docker container. 👍 |
…with docker node (facebook#620) * Specify cache directory for babel loader * Use `react-scripts` for folder name instead
Upgrade `babel-loader` and remove the cache directory configuration that was added in facebook#620. `babel-loader` now uses the `./node_modules/.cache/babel-loader` directory by default, so the custom config is no longer needed.
Upgrade `babel-loader` and remove the cache directory configuration that was added in #620. `babel-loader` now uses the `./node_modules/.cache/babel-loader` directory by default, so the custom config is no longer needed.
Upgrade `babel-loader` and remove the cache directory configuration that was added in facebook#620. `babel-loader` now uses the `./node_modules/.cache/babel-loader` directory by default, so the custom config is no longer needed.
Upgrade `babel-loader` and remove the cache directory configuration that was added in facebook#620. `babel-loader` now uses the `./node_modules/.cache/babel-loader` directory by default, so the custom config is no longer needed.
Upgrade `babel-loader` and remove the cache directory configuration that was added in facebook#620. `babel-loader` now uses the `./node_modules/.cache/babel-loader` directory by default, so the custom config is no longer needed.
Fixes #483
Fixes #612