Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local yarn create-react-app for local testing before publish #6342

Merged
merged 1 commit into from
Feb 5, 2019
Merged

fix local yarn create-react-app for local testing before publish #6342

merged 1 commit into from
Feb 5, 2019

Conversation

gottfired
Copy link
Contributor

When running "yarn create-react-app my-app" to test local scripts changes in a CRA-fork it will fail with "You have provided more than one argument for ". This fixes the bug by moving the project dir to the front.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pick-up, thanks @gottfired.

@mrmckeb mrmckeb merged commit 1648ce8 into facebook:master Feb 5, 2019
@lock lock bot locked and limited conversation to collaborators Feb 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants