Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ie 11 to browserslist for googlebot #6345

Closed

Conversation

saranshkataria
Copy link
Contributor

Fixes #6271, added ie 11 to browserslist for googlebot

@ianschmitz
Copy link
Contributor

Hey thanks for the PR. I've read the linked issue, but i don't think this PR improves that.

browserslist currently only affects the CSS output, but not the javascript. Currently javascript transpilation ignores browserslist and is forced to compile down to support ie9 as seen in our babel config.

However i would be in favor of the change you've made ("not ie <= 10") to include ie11 in the default browserslist

@saranshkataria
Copy link
Contributor Author

saranshkataria commented Feb 10, 2019

Thanks for the info around browserslist affecting only css. I did not know that.

However i would be in favor of the change you've made ("not ie <= 10") to include ie11 in the default browserslist

Do you want me to make any more changes here?

@stale
Copy link

stale bot commented Mar 12, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Mar 12, 2019
@saranshkataria
Copy link
Contributor Author

still waiting for a response

@stale stale bot removed the stale label Mar 12, 2019
@ianschmitz
Copy link
Contributor

I think this is superseded by #6608

@ianschmitz
Copy link
Contributor

Closing this as our default browserslist now includes ie11.

@ianschmitz ianschmitz closed this Aug 7, 2019
@lock lock bot locked and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default browserslist should include Googlebot (Chrome 41)
3 participants