Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployInstruction: Alt+click link appends comma at end #6511

Merged
merged 1 commit into from
Feb 24, 2019

Conversation

sbimochan
Copy link
Contributor

At deploy instruction, the generate publicUrl link is appended with comma and while clicking the link browser opens it with comma at end in my machine. [Mac pro 2016| Chrome Version 71.0.3578.98]
For e.g:
To publish it at http://sbimochan.github.io, run:

This "http://sbimochan.github.io, " gets into browser.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@ianschmitz ianschmitz added this to the 2.1.6 milestone Feb 24, 2019
@ianschmitz ianschmitz merged commit ff19e0a into facebook:master Feb 24, 2019
@ianschmitz
Copy link
Contributor

Thanks!

@sbimochan
Copy link
Contributor Author

@ianschmitz Hi. I just realized that the issue is at terminal of vs-code. You can try at your machine.

@lock lock bot locked and limited conversation to collaborators Mar 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants