Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed not working websocket proxy #6515

Closed
wants to merge 4 commits into from
Closed

Fixed not working websocket proxy #6515

wants to merge 4 commits into from

Conversation

mxschmitt
Copy link

Hello

this PR fixes that websockets, e.g. via Socket.io won't be proxied through the HTTP proxy.
For more information check out issue: #5280 there are also some users who tested it successfully.

Best regards

Max

Fixed that websockets, e.g. via Socket.io won't be proxied through the HTTP Proxy.
@mxschmitt mxschmitt changed the title Patch 1 Fixed not working websocket proxy Feb 25, 2019
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mxschmitt, can you please help me to understand the /sockjs-node/ part of this? Why do we exclude that?

Co-Authored-By: mxschmitt <max@schmitt.mx>
@mxschmitt
Copy link
Author

mxschmitt commented Mar 14, 2019

Hey @mxschmitt, can you please help me to understand the /sockjs-node/ part of this? Why do we exclude that?

@mrmckeb the socksjs part is there, because the proxy should not proxy the request from the auto reloading server to the other server. So I don't saw another solution to implement it by the path name.

// Enable hot reloading server. It will provide /sockjs-node/ endpoint
// for the WebpackDevServer client so it can learn when the files were
// updated. The WebpackDevServer client is included as an entry point
// in the Webpack development configuration. Note that only changes
// to CSS are currently hot reloaded. JS changes will refresh the browser.
hot: true,

@stale
Copy link

stale bot commented May 15, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label May 15, 2019
@mxschmitt mxschmitt closed this May 16, 2019
@lock lock bot locked and limited conversation to collaborators May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants