Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error of jest test over node 11.11 #6592

Closed
wants to merge 5 commits into from
Closed

Fix error of jest test over node 11.11 #6592

wants to merge 5 commits into from

Conversation

micalgenus
Copy link

@micalgenus micalgenus commented Mar 7, 2019

fix #6591

I think I can solve the issue as follows. It is a problem to change the version of the module.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@micalgenus micalgenus changed the title Update jest version Fix error of jest test over node 11.11 Mar 7, 2019
@micalgenus
Copy link
Author

Sorry. I can not solve the "kitchensink-eject" test.

@micalgenus
Copy link
Author

I do not know why the code is the same but the results are different.

3rd commit
Fix error of resolver not found in travis-ci c55a951:
https://travis-ci.org/facebook/create-react-app/builds/503219173?utm_source=github_status&utm_medium=notification
c55a951e1ed2a7426316fa3e484d61c022e3fe0c

5th commit
Update babel-jest version from 23.6 to 24.3 6bbdc70:
https://travis-ci.org/facebook/create-react-app/builds/503237557?utm_source=github_status&utm_medium=notification
6bbdc707d250adb58b282dd126e3ebaea5b71b93

diff

@ianschmitz
Copy link
Contributor

This is a dupe of #6278.

@ianschmitz ianschmitz closed this Mar 9, 2019
@lock lock bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest error in Node version over 11.11
3 participants