Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineChunkHtmlPlugin works with empty publicPath #6735

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

ItalyPaleAle
Copy link
Contributor

The InlineChunkHtmlPlugin plugin didn't work when the publicPath variable is empty or unset (e.g. when I want to use relative URLs).

Before:

  • If publicPath was unset or wasn't a string, webpack would throw an error
  • If publicPath was an empty string, the plugin would fail to inline a chunk

Now: the plugin behaves as expected even with empty or unset publicPath.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Co-Authored-By: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@Timer
Copy link
Contributor

Timer commented Apr 1, 2019

n.b. for other reviewers, this is not a bug. It only affects users who eject from Create React App or use our plugins in non-CRA applications.

@ItalyPaleAle
Copy link
Contributor Author

ItalyPaleAle commented Apr 1, 2019

I mean, it is a bug. It just happens to only affect people who eject from CRA (like my case). Still, it's not less of a bug :)

@ItalyPaleAle
Copy link
Contributor Author

@Timer any update on this? When can it be merged?

@ItalyPaleAle
Copy link
Contributor Author

Ping :)

@iansu iansu closed this Apr 16, 2019
@iansu iansu reopened this Apr 16, 2019
@iansu iansu added this to the 3.0 milestone Apr 16, 2019
@iansu iansu merged commit fdbb550 into facebook:master Apr 16, 2019
@iansu
Copy link
Contributor

iansu commented Apr 16, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Apr 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants