Add test for special scripts versions #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gaearon
suggested changes
Sep 19, 2016
| # Test special scripts versions | ||
| create_react_app --scripts-version=0.4.0 test-app-version-number | ||
| create_react_app --scripts-version=https://registry.npmjs.org/react-scripts/-/react-scripts-0.4.0.tgz test-app-tarball-url | ||
| create_react_app --scripts-version=react-scripts-fork test-app-fork |
There was a problem hiding this comment.
We should at least test something. Perhaps that the created project contains the corresponding fork in node_modules.
There was a problem hiding this comment.
Added some asserts.
gaearon
approved these changes
Sep 19, 2016
|
Yay. Thank you so much! |
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I published a
react-scripts-forkpackage to npm for testing.