Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-no-duplicate-props ignore case fix #7230

Merged
merged 4 commits into from
Jul 16, 2019
Merged

jsx-no-duplicate-props ignore case fix #7230

merged 4 commits into from
Jul 16, 2019

Conversation

rommguy
Copy link
Contributor

@rommguy rommguy commented Jun 16, 2019 •
edited by ianschmitz
Loading

Fixes #6956.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@rommguy rommguy mentioned this pull request Jun 16, 2019
Closed
@rommguy
Copy link
Contributor Author

rommguy commented Jun 16, 2019

This PR fixes #6956

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rommguy @ianschmitz
Update packages/eslint-config-react-app/index.js
ae5840a 
Co-Authored-By: Ian Schmitz <ianschmitz@gmail.com>
@ianschmitz ianschmitz added this to the 3.0.2 milestone Jun 18, 2019
@rommguy
Copy link
Contributor Author

rommguy commented Jul 9, 2019

@ianschmitz Any chance this will be merged soon?

@ianschmitz ianschmitz changed the title Eslint ignore case fix jsx-no-duplicate-props ignore case fix Jul 16, 2019
@ianschmitz ianschmitz merged commit 2d57fa3 into facebook:master Jul 16, 2019
@rommguy
Copy link
Contributor Author

rommguy commented Jul 16, 2019

Thanks @ianschmitz

@rommguy rommguy deleted the eslint-ignore-case-fix branch July 16, 2019 18:08
@lock lock bot locked and limited conversation to collaborators Jul 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bugzpodder bugzpodder bugzpodder approved these changes

@ianschmitz ianschmitz ianschmitz approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@gaearon gaearon Awaiting requested review from gaearon

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

Why ignoring casing on jsx-no-duplicate-props?
4 participants
@rommguy @facebook-github-bot @ianschmitz @bugzpodder