Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "jsx-a11y/aria-role" for React components #7393

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Ignore "jsx-a11y/aria-role" for React components #7393

merged 1 commit into from
Aug 12, 2019

Conversation

deftomat
Copy link
Contributor

As described in docs, jsx-a11y/aria-role ESLint rule can be disabled for non-DOM elements.

I'm pretty sure that we want to check only native HTML elements as a lot of developers can struggle when we raise a warning for the role property in their custom React components.

Copy link
Contributor

@ianschmitz ianschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wonder why we haven't heard more people complaining about this?

@ianschmitz ianschmitz modified the milestones: 3.x, 3.1.1 Aug 12, 2019
@ianschmitz ianschmitz merged commit 413e7c8 into facebook:master Aug 12, 2019
@ianschmitz
Copy link
Contributor

Thanks @deftomat !

@conor-cafferkey-sociomantic
Copy link

conor-cafferkey-sociomantic commented Aug 14, 2019

Looks good. I wonder why we haven't heard more people complaining about this?

Amazing, thanks for this! I was literally just about to open an issue “complaining” about it 😄

@deftomat
Copy link
Contributor Author

You're welcome!

@lock lock bot locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants