Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add question issue template #7423

Merged
merged 4 commits into from
Jul 25, 2019
Merged

Add question issue template #7423

merged 4 commits into from
Jul 25, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Jul 24, 2019 •
edited
Loading

Add a new question issue template that directs users to Spectrum.

I also added a new needs triage label to the existing issue templates.

mrmckeb
mrmckeb suggested changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @iansu. One small change request, otherwise good to merge.

.github/ISSUE_TEMPLATE/bug_report.md Outdated
1.
2.
3.
1. 2. 3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came from GitHub's template, the new format is causing strange output:
image

It might be best to revert this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even realize I changed that. Must be VSCode's Markdown formatter. I'll revert it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's actually prettier that does this in the pre-commit hook. I had to edit it directly in GitHub to get around that. 😞

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... strange. But at least you got it sorted.

I think the original had a space between each line - perhaps that was why.

@iansu iansu merged commit 498913d into facebook:master Jul 25, 2019
@iansu iansu deleted the question-issue-template branch July 25, 2019 16:39
@lock lock bot locked and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrmckeb mrmckeb mrmckeb requested changes

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iansu @mrmckeb @facebook-github-bot