Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show logo for mobile views in create-react-app.dev #7521

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

GrooChu
Copy link
Contributor

@GrooChu GrooChu commented Aug 13, 2019

This PR fixes issue #7517
Create react is not being displayed in create-react-app.dev page because docusaurus by default hides the logo for mobile view. Fix here involves displaying the the logo for all the resolutions. https://github.com/facebook/docusaurus/blob/bd72aacfe85c2e239d6d92486850b5a229cda836/packages/docusaurus-1.x/lib/static/css/main.css#L592
Screen Shot 2019-08-13 at 1 53 41 PM

@GrooChu GrooChu requested review from amyrlam and iansu as code owners August 13, 2019 08:40
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu iansu self-assigned this Aug 13, 2019
Co-Authored-By: Ian Sutherland <ian@iansutherland.ca>
@iansu iansu added this to the 3.1.2 milestone Aug 14, 2019
@iansu iansu merged commit 437b83f into facebook:master Aug 14, 2019
@iansu
Copy link
Contributor

iansu commented Aug 14, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants