Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update running-tests.md #7659

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Update running-tests.md #7659

merged 1 commit into from
Sep 9, 2019

Conversation

weyert
Copy link
Contributor

@weyert weyert commented Sep 7, 2019

Fixed the unit test in the @testing-library bit of the page as Welcome to React is not being used in the App.js.

Made the change in newly created CRA app and ran the tests in Gitlab CI:

$ react-scripts test
PASS src/App.test.js
  ✓ renders welcome message (82ms)

@weyert
Update running-tests.md
c1afc66 
Fixed the  unit test in the @testing-library bit of the page as Welcome to React is not being used in the `App.js`
@weyert weyert requested review from amyrlam and iansu as code owners September 7, 2019 22:25
@iansu iansu added this to the 3.1.2 milestone Sep 9, 2019
@iansu iansu merged commit 0f9e350 into facebook:master Sep 9, 2019
@iansu
Copy link
Contributor

iansu commented Sep 9, 2019

Thanks!

VasilyShelkov pushed a commit to VasilyShelkov/create-react-extension that referenced this pull request Sep 9, 2019
@weyert @VasilyShelkov
Update running-tests.md (facebook#7659)
bf170f2
@lock lock bot locked and limited conversation to collaborators Sep 14, 2019
@weyert weyert deleted the patch-1 branch November 24, 2019 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam

@iansu iansu Awaiting requested review from iansu

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@weyert @iansu @facebook-github-bot