Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alex to lint documentation #7852

Merged
merged 4 commits into from
Oct 24, 2019
Merged

Add Alex to lint documentation #7852

merged 4 commits into from
Oct 24, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Oct 21, 2019

This sets up Alex to lint our docs. We're also going to have to update some of the docs so they pass the linter and possibly deactivate some of the rules.

I also thought this would be a good time to try out GitHub Actions but it seems like it's not enabled on Facebook's account or maybe just this repo? 😂

cc @JoelMarcey

Copy link
Contributor

@andriijas andriijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet addition!

@endiliey
Copy link
Contributor

I also thought this would be a good time to try out GitHub Actions but it seems like it's not enabled on Facebook's account or maybe just this repo?

I think only this repo. We are able to setup GH Actions on Docusaurus. cc @JoelMarcey to enable it for CRA 😉

@JoelMarcey
Copy link
Contributor

It looks to be enabled already for this repo 🤔

Screenshot 2019-10-21 18 52 00

@iansu
Copy link
Contributor Author

iansu commented Oct 22, 2019

It's running on my fork so this config appears to be correct. Maybe it's not running in the PR because the config isn't present in this repo on master? I'm going to try making and merging another PR that just runs ESLint in an action.

@iansu
Copy link
Contributor Author

iansu commented Oct 22, 2019

Okay, that actually worked in my other branch. I think this makes sense. GitHub won't run actions that are defined in PRs from a fork. Otherwise people could basically DOS your CI I guess? Or do other bad things.

"colors",
"conservative",
"crashes",
"executed",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the software industry uses a lot of aggressive words to describe things.

@iansu iansu added this to the 3.3 milestone Oct 24, 2019
@iansu iansu merged commit 1d03579 into facebook:master Oct 24, 2019
@iansu iansu deleted the alexjs branch October 24, 2019 18:14
@lock lock bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants