Add root imports with tilde prefix #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `babel-plugin-root-import` to the default .babelrc file to define `~` as the absolute path to the src/ folder. This gives us the possibility to turn code like this: ``` import SomeUtility from '../../utils/some-utility' ``` to this ``` import SomeUtility from '~/utils/some-utility'; ```
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thanks for the PR but this is not the approach we’re likely to take because it breaks many integrations and third-party tools. Instead, we intend to implement this approach: #741. If you could research that, and submit a PR for it, it would be very welcome! |
|
Oh... okay. |
|
@selbekk any update on this matter? I'm using the ducks model for my file structure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
babel-plugin-root-importto the default.babelrcfile to define~as the absolute path to thesrc/folder.This gives us the possibility to turn code like this:
to this
The main upside of using this pattern in contrary to the approaches suggested in #741 is that it highlights what is a local import and what is a
node_moduleimport.Fixes #849.