Create asset filenames mapping on the build output #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use danethurber/webpack-manifest-plugin on Webpack production configuration to create a file named `asset-manifest.json` which contain a mapping of all asset filenames to their corresponding output file. `asset-manifest.json` will be located at the root of output folder. This'll resolve facebook#600
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
gaearon
suggested changes
Oct 11, 2016
| @@ -250,7 +251,10 @@ module.exports = { | |||
| } | |||
| }), | |||
| // Note: this won't work without ExtractTextPlugin.extract(..) in `loaders`. | |||
| new ExtractTextPlugin('static/css/[name].[contenthash:8].css') | |||
| new ExtractTextPlugin('static/css/[name].[contenthash:8].css'), | |||
| new ManifestPlugin({ | |||
There was a problem hiding this comment.
This needs a comment explaining why it is useful
| @@ -65,6 +65,7 @@ | |||
| "url-loader": "0.5.7", | |||
| "webpack": "1.13.2", | |||
| "webpack-dev-server": "1.16.1", | |||
| "webpack-manifest-plugin": "^1.0.1", | |||
There was a problem hiding this comment.
Please keep versions exact
There was a problem hiding this comment.
Fixed its version to be exactly 1.0.1
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
LGTM. Thank you! |
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
* Create asset filenames mapping on the build output I use danethurber/webpack-manifest-plugin on Webpack production configuration to create a file named `asset-manifest.json` which contain a mapping of all asset filenames to their corresponding output file. `asset-manifest.json` will be located at the root of output folder. This'll resolve facebook#600 * Add an explanation for ManifestPlugin * Make webpack-manifest-plugin's version exact
jarlef
pushed a commit
to jarlef/create-react-app
that referenced
this pull request
Nov 28, 2016
* Create asset filenames mapping on the build output I use danethurber/webpack-manifest-plugin on Webpack production configuration to create a file named `asset-manifest.json` which contain a mapping of all asset filenames to their corresponding output file. `asset-manifest.json` will be located at the root of output folder. This'll resolve facebook#600 * Add an explanation for ManifestPlugin * Make webpack-manifest-plugin's version exact
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #600
I use webpack-manifest-plugin on Webpack production configuration to create a file named
asset-manifest.jsonwhich contain a mapping of all asset filenames to their corresponding output file.asset-manifest.jsonwill be located at the root of output folder.Here's the example from a newly created project.
{ "main.css": "static/css/main.9a0fe4f1.css", "main.css.map": "static/css/main.9a0fe4f1.css.map", "main.js": "static/js/main.c9af8c27.js", "main.js.map": "static/js/main.c9af8c27.js.map", "static/media/logo.svg": "static/media/logo.5d5d9eef.svg" }You can see that it doesn't map those files from
public/. What do you think?