-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BuildProgressPlugin #950
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Using the same technique used in https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/config/paths.js#L74, I changed |
Sorry, I had no time to look at this yet. I will, can you please reopen?
But we are assuming specific plugins in |
I figured I'd take a stab at #935 since it seemed relatively easy.
I do have a concern though!
I created the plugin in
react-dev-utils
per suggestion in #935, however this resulted in addingwebpack
as a dependency 😱 -- it was listed as a peerDependency previously (which fails to resolve post lerna/lerna#318).Would it be better to implement it in
react-scripts
and addprogress
as a dependency? Or would you rather explore a solution which doesn't useprogress
?edit: read below