Skip to content

Commit

Permalink
fix(v2): navbar, allow unknown attributes (#3140)
Browse files Browse the repository at this point in the history
  • Loading branch information
slorber authored Jul 28, 2020
1 parent 33bb908 commit d1a27ef
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/docusaurus-theme-classic/src/themeConfigSchema.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ const DefaultNavbarItemSchema = Joi.object({
activeBaseRegex: Joi.string(),
className: Joi.string(),
'aria-label': Joi.string(),
});
})
// We allow any unknown attributes on the links
// (users may need additional attributes like target, aria-role, data-customAttribute...)
.unknown();
// TODO the dropdown parent item can have no href/to
// should check should not apply to dropdown parent item
// .xor('href', 'to');
Expand Down

0 comments on commit d1a27ef

Please sign in to comment.