Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): navbar item links should allow unknown attributes #3140

Merged
merged 1 commit into from
Jul 28, 2020
Merged

fix(v2): navbar item links should allow unknown attributes #3140

merged 1 commit into from
Jul 28, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 28, 2020

Motivation

Fix ability to provide link target for example #3139

@slorber slorber requested a review from lex111 as a code owner July 28, 2020 10:03
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 28, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 28, 2020
@slorber slorber mentioned this pull request Jul 28, 2020
Closed
@slorber slorber linked an issue Jul 28, 2020 that may be closed by this pull request
ValidationError: "navbar.items.target" is not allowed #3139
Closed
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit e5ff0fb

https://deploy-preview-3140--docusaurus-2.netlify.app

@slorber slorber merged commit d1a27ef into master Jul 28, 2020
@yangshun yangshun deleted the slorber/navbar-items-link-unknown branch August 26, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValidationError: "navbar.items.target" is not allowed
3 participants
@slorber @docusaurus-bot @facebook-github-bot