Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseUrl banner: make the message configurable please Google/SEO/indexers #4028

Closed
Morriz opened this issue Jan 12, 2021 · 13 comments · Fixed by #4125
Closed

BaseUrl banner: make the message configurable please Google/SEO/indexers #4028

Morriz opened this issue Jan 12, 2021 · 13 comments · Fixed by #4125
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future.

Comments

@Morriz
Copy link

Morriz commented Jan 12, 2021

🚀 Feature

Currently this message is indexed (google it) on ALL sites using docusaurus:

"Your Docusaurus site did not load properly."

It would be nice to let us configure that message so that we at least have some control over our crawl presence on the web.

Have you read the [Contributing Guidelines on issues]

yes

@Morriz Morriz added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. status: needs triage This issue has not been triaged by maintainers labels Jan 12, 2021
@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Jan 12, 2021
@slorber
Copy link
Collaborator

slorber commented Jan 12, 2021

Thanks for reporting this.

Can you explain how this affects your site exactly?

I mean, no one is googling for "Your Docusaurus site did not load properly.", so how did you find it was a problem, and how customizing the message will solve it?

Maybe we should also add an opt-in option to remove it?

@Morriz
Copy link
Author

Morriz commented Jan 13, 2021

I see a lot of docusaurus doc sites be indexed by google that way, probably since it is hosted as static only.

I was just offering you to search for that exact string so you can see the scale of the problem.

Maybe crawlers can be told to ONLY index meta description instead of that message, but I am not very deep into html specs any more...

@slorber
Copy link
Collaborator

slorber commented Jan 13, 2021

https://www.google.com/search?q=%22Your+Docusaurus+site+did+not+load+properly.%22&rlz=1C5CHFA_enFR749FR749&oq=%22Your+Docusaurus+site+did+not+load+properly.%22&aqs=chrome.0.69i59.4303j0j7&sourceid=chrome&ie=UTF-8

I do agree that these Docusaurus 2 sites get indexed in an unexpected way, and we should likely offer a way to disable that.

I just wonder why specifically it is a problem for you and your users?
How does it impact your business/SEO in a concrete way?
What did a regular user type, and why was he disappointed?

It is very unlikely that a user will type such a string on Google, and when searching for "Docusaurus 2"

image

I'm just trying to understand better your motivations to figure out the best way to do something about it.

Maybe by default we could write "your site www.xyz.com did not load properly" or something?

Does a new config option really solve the problem? As many site owners wouldn't even be aware of that option?

@Morriz
Copy link
Author

Morriz commented Jan 18, 2021

Look, I really don't care what REAL people see that have javascript turned off (I regard them as weirdos and not part of our target population), so I'd rather cater to the CRAWLERS, and get a nice message on google et al.

@Morriz
Copy link
Author

Morriz commented Jan 18, 2021

I found our site to be indexed with that message, so it's not about how and via what route I found out about that. Only then did I do an extra search for that string, to reveal the scale of this.

@Morriz
Copy link
Author

Morriz commented Jan 18, 2021

I have to say I am not aware anymore of what I searched for, but it was the day of a media announcement and was generating some keyword combos and then saw it indexed like that. I just tried some again but can't reproduce.

@slorber
Copy link
Collaborator

slorber commented Jan 19, 2021

I understand.
Will try to find a solution, not sure I can totally prevent it to be indexed but at least it should be possible to disable/customize it.

@Morriz
Copy link
Author

Morriz commented Jan 22, 2021

Thanks for being so sweet. Sorry about my hammering. It's no prio.

@slorber
Copy link
Collaborator

slorber commented Jan 29, 2021

Hey,

Totally forgot about this, but it's already possible to disable this message 😅

https://v2.docusaurus.io/docs/next/docusaurus.config.js/#baseurlissuebanner

Still trying to find a solution, will attempt a few things to make the message not indexed by default, but not sure about the Google Crawler behavior :

@slorber
Copy link
Collaborator

slorber commented Jan 29, 2021

#4125

This PR will ensure that the help banner is not server-rendered anymore. This should prevent the google indexation.

As it is possible to disable this banner with config, and it should normally not be indexed anymore, I don't think it's worth it to be able to customize that message.

Going to close this for now, but we'll check if the message is still indexed or not soon.

@slorber slorber changed the title Make configurable no-javascript message to please indexers BaseUrl banner: make the message configurable please Google/SEO/indexers Jan 29, 2021
@kkhoury38
Copy link

kkhoury38 commented Jan 29, 2021 via email

@slorber
Copy link
Collaborator

slorber commented Jan 29, 2021 via email

@slorber
Copy link
Collaborator

slorber commented Feb 19, 2021

Searching for site:v2.docusaurus.io + "your docusaurus site did not load properly." does not show any result with that exact string, so it should be fixed in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants