Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): baseUrl help banner should not be indexed by Google / SEO #4125

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jan 29, 2021

Motivation

#4028

The help banner that is visible when the site baseUrl is badly configured gets indexed by Google by mistake (despite being made invisible on sites correctly configured, thanks to critical CSS)

image

This PR changes the way this banner is rendered:

  • The banner is not server-rendered anymore (not in static HTML files)
  • The banner is rendered on the client, using critical inlined JS

This should theoretically ensure Google will not index that string (can't be 100% sure)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Production

@netlify
Copy link

netlify bot commented Jan 29, 2021

[V1] Deploy preview success

Built with commit cba0f4c

https://deploy-preview-4125--docusaurus-1.netlify.app

@github-actions
Copy link

Size Change: +4 B (0%)

Total Size: 28.8 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.8 kB +3 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.87 kB +1 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Jan 29, 2021

Deploy preview for docusaurus-2 ready!

Built with commit cba0f4c

https://deploy-preview-4125--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 87
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4125--docusaurus-2.netlify.app/classic/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseUrl banner: make the message configurable please Google/SEO/indexers
3 participants