Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): Improve SSR error message: log page path #3609

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 19, 2020

Motivation

Put bad markup in a MDX file:

image

On build, you get this kind of unactionable error:

image

To make this error more actionable, we should log the page path for which we couldn't render:

image

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

local test

@slorber slorber requested a review from lex111 as a code owner October 19, 2020 18:09
@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Oct 19, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 19, 2020
@slorber slorber changed the title polish(v2): Improve SSR error message: log page path refactor(v2): Improve SSR error message: log page path Oct 19, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit c5b9df5

https://deploy-preview-3609--docusaurus-2.netlify.app

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

@slorber slorber merged commit c340ee1 into master Oct 20, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
@slorber slorber deleted the slorber/better-ssr-error branch August 17, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants