Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): make even better SSR error notify and add tip #4875

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 31, 2021

Motivation

A kind of continuation of #3609 created after #4836.

At the moment SSR errors are not very informative, we can give the user a tip on how to resolve most common error kind of "x is not defined". We will also print full stack trace to provide guidance in fixing other SSR errors.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Add console.log(document.title); call to the Home component along path src/page/index.js

Before After
image image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@netlify
Copy link

netlify bot commented May 31, 2021

✔️ [V2]

🔨 Explore the source changes: 9fd3d5f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60b50d26894f190007bdcc56

😎 Browse the preview: https://deploy-preview-4875--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 59
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4875--docusaurus-2.netlify.app/

@netlify
Copy link

netlify bot commented May 31, 2021

✔️ [V1]

🔨 Explore the source changes: 9fd3d5f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-1/deploys/60b50d2689e4a60007ecdab3

😎 Browse the preview: https://deploy-preview-4875--docusaurus-1.netlify.app

@github-actions
Copy link

Size Change: 0 B

Total Size: 620 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 88.1 kB 0 B
website/build/assets/js/main.********.js 443 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.1 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 26.9 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jun 2, 2021

Thanks, wanted to add something similar.

I'd like to create dedicated documentation pages for such errors and link to them directly in error messages. Those instructions are a good first step in that direction 👍

@slorber slorber merged commit 15d4519 into master Jun 2, 2021
@slorber slorber deleted the lex111/iss4836 branch August 17, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants