Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Vietnamese translations #5781

Merged
merged 4 commits into from
Oct 26, 2021
Merged

refactor: Vietnamese translations #5781

merged 4 commits into from
Oct 26, 2021

Conversation

datlechin
Copy link
Contributor

Fix plural theme.blog.post.readingTime.plurals
Fix grammar theme.lastUpdated.lastUpdatedAtBy

Motivation

Better translations

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No tests required

Related PRs

n/a

Fix plural `theme.blog.post.readingTime.plurals`
Fix grammar `theme.lastUpdated.lastUpdatedAtBy`

### Motivation
Better translations

### Have you read the Contributing Guidelines on pull requests?
Yes

### Test Plan
No tests required

### Related PRs
n/a
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 25, 2021
@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: cbf8a38

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61763a11bedb210007008efb

😎 Browse the preview: https://deploy-preview-5781--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 25, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 94
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5781--docusaurus-2.netlify.app/

@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: d1b4fc1

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61763b223a194e0008204d7b

😎 Browse the preview: https://deploy-preview-5781--docusaurus-2.netlify.app

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Oct 26, 2021
@lex111 lex111 merged commit 4902001 into facebook:main Oct 26, 2021
@lex111
Copy link
Contributor

lex111 commented Oct 26, 2021

@datlechin thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants