Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process #2824

Closed
skovhus opened this issue Nov 16, 2016 · 1 comment
Closed

child_process #2824

skovhus opened this issue Nov 16, 2016 · 1 comment

Comments

@skovhus
Copy link

skovhus commented Nov 16, 2016

I think I discovered some missing type definitions for stdio options to child_process calls to execFileSync, execSync and spawnSync.

Actually this is also seems to be missing in node.js documentation (see nodejs/node#9636).

The options.stdio argument to execFileSync, execSync and spawnSync can actually be a string and an array.

In lib/node.js it also seems that execFileSync is using the incorrect options type... It should use child_process$execSyncOpts not child_process$execFileOpts.

argsOrOptions?: Array<string> | child_process$execFileOpts,

skovhus added a commit to skovhus/flow that referenced this issue Nov 16, 2016
skovhus added a commit to skovhus/flow that referenced this issue Nov 16, 2016
@skovhus
Copy link
Author

skovhus commented Nov 19, 2016

My pull request for node has now been accepted, so the current flow definitions should be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant