Update execSyncOpts to support string and array for stdio

Fixes: facebook#2824
skovhus · Dec 2, 2016 · a3f54a2 · a3f54a2
1 parent b301a3d
commit a3f54a2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/node.js b/lib/node.js
@@ -142,7 +142,7 @@ type child_process$execCallback = (error: ?child_process$Error, stdout: string |
 type child_process$execSyncOpts = {
   cwd?: string;
   input?: string | Buffer;
-  stdio?: Array<any>;
+  stdio?: string | Array<any>;
   env?: Object;
   shell?: string,
   uid?: number;

diff --git a/tests/node_tests/child_process/execSync.js b/tests/node_tests/child_process/execSync.js
@@ -6,3 +6,5 @@ var execSync = require('child_process').execSync;
 (execSync('ls', {encoding: 'buffer'}): Buffer); // returns Buffer
 (execSync('ls', {encoding: 'utf8'}): string); // returns string
 (execSync('ls', {timeout: '250'})); // error, no signatures match
+(execSync('ls', {stdio: 'inherit'})); // error, no signatures match
+(execSync('ls', {stdio: ['inherit']})); // error, no signatures match