Add emoji to server status messages #3000
Conversation
|
Should we make emoji the default? ❤️ if yes, 🎉 if no. |
|
Regarding the default - how widespread is emoji support? That would be my main concern with turning this on by default. @vkurchatkin - what concerns do you have? |
|
@gabelevi I think this change provides little to none benefit, but introduces a risk of breaking someone's setup |
|
@Daniel15 what's emoji support like in Windows? |
This change adds emoji to the various server status messages printed by flow. These messages are usually seen in square brackets with labels like "parsing" or "merging inference". The new behavior is configurable via the "emoji" option in `.flowconfig`. It's enabled by default, so to opt-out you must add: ``` [options] emoji=false ```
|
I've changed my mind and made the current behavior (no emoji) the default. So it's now opt-in. Also added a line in the docs about it. |
Not too good, unfortunately. They work in some configurations (for example, they work for me in Cmder), but they appear small and black-and-white. It seems like the new colourful Emoji can't be rendered in command-line apps yet. It seems like vanilla cmd.exe/conhost.exe don't support Emoji at all. See yarnpkg/yarn#405 |
|
Thanks @Daniel15! @samwgoldman after seeing yarnpkg/yarn/issues/405, I'll try to do something similar - I'll add a TTY check and exclude windows. |
|
@samwgoldman has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
hm, this does not seem to work. I specify I get |
|
This was released in Flow 0.38.0 (https://github.com/facebook/flow/releases/tag/v0.38.0) |
This change adds emoji to the various server status messages printed by flow. These messages are usually seen in square brackets with labels like "parsing" or "merging inference". The new behavior is configurable via the
emojioption in.flowconfig, but will only be used in non-Windows platforms. It's disabled by default, so to opt-in you must add:Test plan (on a Mac):
make testflowwith an empty flowconfig and didn't see emoji.flowwith a.flowconfigthat hademoji=trueunder[options], and saw emoji.flowagain, and saw the appropriate emoji given the config.flow | catwith emoji enabled and didn't see any emoji.make jsandnode -p 'require("./bin/flow.js").checkContent("-", "// @flow\n(1: string);")'- this showed the correct error.