Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for $Shape - Resolves #5246 #5251

Closed
wants to merge 1 commit into from

Conversation

aikar
Copy link

@aikar aikar commented Nov 2, 2017

No description provided.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@MichaelDeBoey
Copy link

Thanks for this one @aikar! 🙂

@MichaelDeBoey
Copy link

I think this can be merged after the conflict is solved?

CC: @asolove @samwgoldman @mroch @nmote

@mvitousek
Copy link
Contributor

It looks like #6694, which was merged last year, contained similar documentation for $Shape. Thank you for the contribution, and sorry we didn't get a chance to review and merge your diff; feel free to reopen if there's anything in your commit that didn't get included in the docs as they exist now which you'd like us to have a closer look at.

@mvitousek mvitousek closed this Feb 7, 2019
@mvitousek mvitousek self-assigned this Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants