Implement isDefaultValueConstant and fix getDefaultValueConstantName #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 17, 2014 16:04
The 'defaultText' field inside the 'info' array of a ReflectionParameter instance is matched against a regex that checks if it complies with the accepted format for labels and constants names. Then it checks whether or not it is one of the following reserved words: 'NULL', 'false' and 'true'. If it is, then the function returns FALSE. Otherwise, TRUE.
The method getDefaultValueConstantName returns NULL in case the value is NOT a constant; otherwise, it returns the constant's name. To check if the value is indeed a constant, we use the method isDefaultValueConstant method.
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D25095 |
added 5 commits
October 17, 2014 18:58
Correct the doc on return values to lowercase booleans for the isDefaultValueConstant method. Add return of NULL (to the method cited above) when the given argument does not have a default value.
sgolemon
changed the title
|
@lucastadeu Hi. As discussed on the pull request comments, we are abandoning this pull request in favor of another approach. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3812
Closes #3828.