Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement isDefaultValueConstant and fix getDefaultValueConstantName #4009

Closed
wants to merge 8 commits into from
Closed

Implement isDefaultValueConstant and fix getDefaultValueConstantName #4009

wants to merge 8 commits into from

Commits on Oct 17, 2014

  1. Resolve issue #3812

    The 'defaultText' field inside the 'info' array of a ReflectionParameter
    instance is matched against a regex that checks if it complies with the
    accepted format for labels and constants names.
    
    Then it checks whether or not it is one of the following reserved words:
    'NULL', 'false' and 'true'. If it is, then the function returns FALSE.
    Otherwise, TRUE.
    Lucas Tadeu Teixeira committed Oct 17, 2014
    Configuration menu
    Copy the full SHA
    95c86df View commit details
    Browse the repository at this point in the history
  2. Add tests for the isDefaultValueConstant method from the ReflectionPa…

    …rameter class.
    Lucas Tadeu Teixeira committed Oct 17, 2014
    Configuration menu
    Copy the full SHA
    b7a1c77 View commit details
    Browse the repository at this point in the history
  3. Resolve issue #3828.

    The method getDefaultValueConstantName returns NULL in case the
    value is NOT a constant; otherwise, it returns the constant's name.
    
    To check if the value is indeed a constant, we use the method
    isDefaultValueConstant method.
    Lucas Tadeu Teixeira committed Oct 17, 2014
    Configuration menu
    Copy the full SHA
    46c1d30 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2014

  1. Fix indentation problems.

    Lucas Tadeu Teixeira committed Oct 18, 2014
    Configuration menu
    Copy the full SHA
    375be4f View commit details
    Browse the repository at this point in the history
  2. Add spaces after ifs and brackets.

    Correct the doc on return values to lowercase booleans for the
    isDefaultValueConstant method.
    Add return of NULL (to the method cited above) when the given argument does not
    have a default value.
    Lucas Tadeu Teixeira committed Oct 18, 2014
    Configuration menu
    Copy the full SHA
    8c66d3c View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2014

  1. Fix regex for checking if a parameter is a constant or not.

    Lucas Tadeu Teixeira committed Nov 6, 2014
    Configuration menu
    Copy the full SHA
    4e10a00 View commit details
    Browse the repository at this point in the history
  2. Add missing enclosing parenthesis.

    Lucas Tadeu Teixeira committed Nov 6, 2014
    Configuration menu
    Copy the full SHA
    d110d55 View commit details
    Browse the repository at this point in the history
  3. Remove extra enclosing parenthesis.

    Lucas Tadeu Teixeira committed Nov 6, 2014
    Configuration menu
    Copy the full SHA
    a9f7447 View commit details
    Browse the repository at this point in the history