Revert Fix $transferStartingElementPointToTextPoint() #4756 (#5094)

packages/lexical/src/LexicalSelection.ts

@@ -244,17 +244,6 @@ function $transferStartingElementPointToTextPoint(
     element.append(target);
   } else {
     placementNode.insertBefore(target);
-    // Fix the end point offset if it refers to the same element as start,
-    // as we've now inserted another element before it. Note that we only
-    // do it if selection is not collapsed as otherwise it'll transfer
-    // both focus and anchor to the text node below
-    if (
-      end.type === 'element' &&
-      end.key === start.key &&
-      end.offset !== start.offset
-    ) {
-      end.set(end.key, end.offset + 1, 'element');
-    }
   }
   // Transfer the element point to a text point.
   if (start.is(end)) {

packages/lexical/src/__tests__/unit/LexicalSelection.test.ts

@@ -9,14 +9,13 @@
 import {$createLinkNode} from '@lexical/link';
 import {
   $createParagraphNode,
-  $createRangeSelection,
   $createTextNode,
   $getRoot,
   LexicalEditor,
   RangeSelection,
 } from 'lexical';
 
-import {$createTestDecoratorNode, initializeUnitTest} from '../utils';
+import {initializeUnitTest} from '../utils';
 
 describe('LexicalSelection tests', () => {
   initializeUnitTest((testEnv) => {
@@ -323,51 +322,6 @@ describe('LexicalSelection tests', () => {
           //   await insertText({container, editor, method: 'insertNodes'});
           // });
         });
-
-        describe('transferStartingElementPointToTextPoint', () => {
-          test('transferStartingElementPointToTextPoint', async () => {
-            const {container, editor} = testEnv;
-
-            if (!container) {
-              throw new Error('Expected container to be truthy');
-            }
-
-            await editor.update(() => {
-              const root = $getRoot();
-              if (root.getFirstChild() !== null) {
-                throw new Error('Expected root to be childless');
-              }
-
-              const paragraph = $createParagraphNode();
-              const text = $createTextNode('Text');
-              const image = $createTestDecoratorNode();
-              paragraph.append(text, image);
-
-              root.append(paragraph);
-
-              expect(root.getTextContent()).toEqual('TextHello world');
-
-              const decoratorIndexInParent = image.getIndexWithinParent();
-              const paragraphKey = paragraph.getKey();
-
-              const selection = $createRangeSelection();
-              selection.anchor.set(
-                paragraphKey,
-                decoratorIndexInParent,
-                'element',
-              );
-              selection.focus.set(
-                paragraphKey,
-                decoratorIndexInParent + 1,
-                'element',
-              );
-
-              selection.insertText('A');
-
-              expect(root.getTextContent()).toEqual('TextA');
-            });
-          });
-        });
       });
     });
   });