Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix $transferStartingElementPointToTextPoint() #4756

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix $transferStartingElementPointToTextPoint() #4756

merged 1 commit into from
Jul 7, 2023

Conversation

amyworrall
Copy link
Contributor

Fix $transferStartingElementPointToTextPoint()

@vercel
Copy link

vercel bot commented Jul 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 9:00pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 9:00pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2023
@amyworrall
Copy link
Contributor Author

Previously there was an issue if both start and end points were of type .element and referred to the same element. When the new text node was inserted, the offset of the end point of the selection was not modified.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 27.96 KB (0%) 560 ms (0%) 327 ms (+25.02% 🔺) 886 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.01 KB (0%) 781 ms (0%) 327 ms (-34.14% 🔽) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 38.98 KB (0%) 780 ms (0%) 503 ms (+20.4% 🔺) 1.3 s

@zurfyx
Copy link
Member

zurfyx commented Jul 7, 2023 •
edited
Loading

LGMT! Let's remove package-lock.json and should be good to go. We don't usually want to include this unless we're intentionally upgrading packages

@amyworrall amyworrall merged commit 5786898 into main Jul 7, 2023
@fantactuka fantactuka mentioned this pull request Jul 10, 2023
Merged
@zurfyx zurfyx mentioned this pull request Jul 11, 2023
Merged
@thegreatercurve thegreatercurve deleted the pr4756 branch October 6, 2023 13:31
thegreatercurve added a commit that referenced this pull request Oct 10, 2023
@thegreatercurve
Revert Fix $transferStartingElementPointToTextPoint() #4756 (#5094)
85fb867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyworrall @zurfyx @facebook-github-bot