Fix inserting link open editor in edit mode #5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
2wheeh
force-pushed
the
fix-insert-link-open-editor
branch
from
15225ac
to
04da320
Compare
2wheeh
force-pushed
the
fix-insert-link-open-editor
branch
from
c906199
to
5613e84
Compare
|
I don't really know much about different selection behaviors per browsers so please let me know if i'v done something wrong here : fix selection assertion |
acywatson
approved these changes
Jan 17, 2024
amanharwara
pushed a commit
to standardnotes/lexical
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5355
The issue seemed to be fixed in #5372 but it got reverted in #5456 because this broke some links, autolinks e2e tests.
It was because #5372 changed scenario of link editor a bit without modifying it in the tests accordingly.
So I added the e2e test modification in this PR.
And plus, #5372 missed the case of floating toolbar, which could be some other issue. (which needs
setIsLinkEditModeto be passed toInlineImageComponenton current implementation so it might need to refactorInlineImageComponent)