Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floating link editor on inline image caption #5460

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Fix floating link editor on inline image caption #5460

merged 1 commit into from
Jan 7, 2024

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented Jan 7, 2024 •
edited
Loading

InlineImageComponent makes two of floating link editor toolbar element and it's triggering some bugs.

before:

before.mov

after:

after.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2024 10:43am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2024 10:43am

@2wheeh 2wheeh mentioned this pull request Jan 7, 2024
Merged
ivailop7
ivailop7 approved these changes Jan 7, 2024
View reviewed changes
Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivailop7 ivailop7 merged commit e2becdd into facebook:main Jan 7, 2024
45 checks passed
@2wheeh 2wheeh deleted the fix-link-editor-buggy-on-inline-image branch January 7, 2024 15:13
amanharwara pushed a commit to standardnotes/lexical that referenced this pull request Jan 18, 2024
@2wheeh @amanharwara
Fix floating link editor on inline image caption (facebook#5460)
5d30d3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2wheeh @ivailop7 @facebook-github-bot