Fix copying html table with unequal number of cells in a row

[KatsiarynaDzibrova]

Issue: when copying html table with not equal number of cells in row the pasted table is broken. The number of cells in each row is different and it breaks on selection.
Fix: adding empty cells on paste

Before:

After:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 17, 2024 10:28am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 17, 2024 10:28am

[facebook-github-bot]

Hi @KatsiarynaDzibrova!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[ivailop7]

Fantastic! Thank you, Katsia!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[ivailop7]

@KatsiarynaDzibrova tests are still failing

[KatsiarynaDzibrova]

@KatsiarynaDzibrova tests are still failing

Looking into it

[zurfyx]

Thank you, have you considered having a transform for this at the plugin level? While I think this approach is correct ultimately we want to lean toward a $normalizer (aka Schemas) which would help mitigate bad structures originating from text input and plugins.

This might also help simplify the additional exported utilities introduced in this PR. WDYT?

[KatsiarynaDzibrova]

Thank you, have you considered having a transform for this at the plugin level? While I think this approach is correct ultimately we want to lean toward a $normalizer (aka Schemas) which would help mitigate bad structures originating from text input and plugins.

This might also help simplify the additional exported utilities introduced in this PR. WDYT?

I thought about implementing it on plugin level, but I assumed that table plugin deals only with cells merging and background color logic.
Can you please explain what do you mean by $normalizer (aka Schemas)? I am not familiar with it

[ivailop7]

ping @zurfyx

[zurfyx]

The normalizer was an example, we definitely want to think about it further before we can propose something generic.

But you can still have the table plugin do these checks for you.

editor.registerTransform(TableCell, node => {
  // validate correct number of cells and rows
});

Because of the current implementation which relies on a full scan of rows and column this might not be very efficient for long tables so we may want to restrict to the paste event for now, you can control this via commands. In the future, we would ideally keep track of the previously explored columns and rows and resume the check from the position instead of scanning the full table.

[KatsiarynaDzibrova]

The normalizer was an example, we definitely want to think about it further before we can propose something generic.

But you can still have the table plugin do these checks for you.

editor.registerTransform(TableCell, node => {
  // validate correct number of cells and rows
});

Because of the current implementation which relies on a full scan of rows and column this might not be very efficient for long tables so we may want to restrict to the paste event for now, you can control this via commands. In the future, we would ideally keep track of the previously explored columns and rows and resume the check from the position instead of scanning the full table.

I agree that it makes sense to trigger this logic only on paste.
But does it mean creating a new command, which will be dispatched in convertTableElement? Because PASTE_COMMAND can't be used here as it's called before the node is created and I don't think there is another existing command that can be used here.
I don't think it's worth creating a new command if we plan to remove it later. Maybe it's better to leave the logic on TableNode level and move it later if the normalizer is created?

[zurfyx]

Thanks for iterating on this and sorry for keeping you blocked for so long, stamping but please address the last comment before merging

[zurfyx]

Let's see how this perform, otherwise we may want to add a check that this only happens strictly on clipboard paste.

@Sahejkm this is the case we discussed offline, ideally this map is cached and future checks are O(1).

[zurfyx]

Suggested change

	export function $computeTableMapSkipCellCheck(grid: TableNode) {
	const [tableMap] = $computeTableMapHelper(grid, null, null);
	return tableMap;
	}

[KatsiarynaDzibrova]

I don't see any changes here

[ivailop7]

@zurfyx I don't see any changes either in the suggestion, did you mean something else here?

[zurfyx]

This function becomes redundant now that the other takes nullable values, doesn't it? Should we use the other function instead?