-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-playground] Fix: in playground show component-menu when scroll #6510
[lexical-playground] Fix: in playground show component-menu when scroll #6510
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
This is essentially undoing: #5859 In the preview for this PR, you can reproduce the issue YOffset was fixing, if you do a very long text, scroll down and do / for the menu to show up, it's rendered incorrectly offscreen. This logic is also used by the Lexical context menu, which you essential fix this for correctly, but break the typeahead when triggered at a lower scrolled page position. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work great for me, I am unable to reproduce any positioning issues with the menu in the scenarios I could find
Description
in playground show component-menu when scroll
Test plan
Before
After